Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16060 )
Change subject: [tests] add same_tablet_concurrent_writes test ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/16060/3/src/kudu/integration-tests/same_tablet_concurrent_writes-itest.cc File src/kudu/integration-tests/same_tablet_concurrent_writes-itest.cc: http://gerrit.cloudera.org:8080/#/c/16060/3/src/kudu/integration-tests/same_tablet_concurrent_writes-itest.cc@214 PS3, Line 214: FLAGS_max_num_columns = kNumColumns; > Would it make sense to use a larger value instead of more columns given 100 You mean have larger cells (like long strings)? Yes: in both cases the desired effect can be achieved, and I updated the test to use smaller number of columns (250), so this is sort of having both high enough number of columns and heavier cells. -- To view, visit http://gerrit.cloudera.org:8080/16060 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7eef6e46e7685450354473cee9d804c5054723eb Gerrit-Change-Number: 16060 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Thu, 09 Jul 2020 18:58:35 +0000 Gerrit-HasComments: Yes