Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16060 )
Change subject: [tests] add same_tablet_concurrent_writes test ...................................................................... Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/16060/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16060/5//COMMIT_MSG@22 PS5, Line 22: https://gerrit.cloudera.org/#/c/16034/ this patch is already merged as da1c66b so I think it would be better to refer to it by commit hash which doesn't require gerrit to be online. http://gerrit.cloudera.org:8080/#/c/16060/5//COMMIT_MSG@29 PS5, Line 29: 16034 same here http://gerrit.cloudera.org:8080/#/c/16060/5/src/kudu/integration-tests/same_tablet_concurrent_writes-itest.cc File src/kudu/integration-tests/same_tablet_concurrent_writes-itest.cc: http://gerrit.cloudera.org:8080/#/c/16060/5/src/kudu/integration-tests/same_tablet_concurrent_writes-itest.cc@222 PS5, Line 222: I think you missed a few words here. http://gerrit.cloudera.org:8080/#/c/16060/5/src/kudu/integration-tests/same_tablet_concurrent_writes-itest.cc@289 PS5, Line 289: spinlock_contentino_time nit: typo in contention -- To view, visit http://gerrit.cloudera.org:8080/16060 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7eef6e46e7685450354473cee9d804c5054723eb Gerrit-Change-Number: 16060 Gerrit-PatchSet: 5 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 10 Jul 2020 14:24:02 +0000 Gerrit-HasComments: Yes
