Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16125 )
Change subject: KUDU-3090 Ownership support in Java client ...................................................................... Patch Set 4: (2 comments) > Patch Set 3: > > Please add some tests for the new API. ok, done. let me know if you think we need additional tests http://gerrit.cloudera.org:8080/#/c/16125/3/java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java File java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java: http://gerrit.cloudera.org:8080/#/c/16125/3/java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java@a262 PS3, Line 262: > why delete this check? not sure, this was in Grant's initial WIP patch, readded it. http://gerrit.cloudera.org:8080/#/c/16125/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestHiveMetastoreIntegration.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestHiveMetastoreIntegration.java: http://gerrit.cloudera.org:8080/#/c/16125/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestHiveMetastoreIntegration.java@a32 PS3, Line 32: > I am not sure why you are deleting this test. Are we still planning to sync not sure, this was in Grant's initial WIP patch, readded it and modified it to check for Kudu ownership as well. -- To view, visit http://gerrit.cloudera.org:8080/16125 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I083ad9750ce1b3ae31bb510b700d1204fcdf291d Gerrit-Change-Number: 16125 Gerrit-PatchSet: 4 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 01 Jul 2020 15:12:35 +0000 Gerrit-HasComments: Yes
