Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16125 )
Change subject: KUDU-3090 Ownership support in Java client ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/16125/7/java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java File java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java: http://gerrit.cloudera.org:8080/#/c/16125/7/java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java@134 PS7, Line 134: * @return this table's owner nit: mind adding something to the effect of "or an empty string if the table was created without an owner on a version of Kudu that didn't automatically assign an owner" or somesuch? For that matter, it might be worth adding a test for what happens if this is called on such a table. Would it make sense to add a Master flag for that, like --set_owner_to_user_if_none_specified or something? Would also be useful in testing the C++ client. -- To view, visit http://gerrit.cloudera.org:8080/16125 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I083ad9750ce1b3ae31bb510b700d1204fcdf291d Gerrit-Change-Number: 16125 Gerrit-PatchSet: 7 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 08 Jul 2020 01:56:57 +0000 Gerrit-HasComments: Yes
