Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16125 )
Change subject: KUDU-3090 Ownership support in Java client ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/16125/3/java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java File java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java: http://gerrit.cloudera.org:8080/#/c/16125/3/java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java@a262 PS3, Line 262: > not sure, this was in Grant's initial WIP patch, readded it. I think the intent was to prevent setting a null or "" owner since that doesn't make much sense given we always expect a table to have an owner. http://gerrit.cloudera.org:8080/#/c/16125/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestHiveMetastoreIntegration.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestHiveMetastoreIntegration.java: http://gerrit.cloudera.org:8080/#/c/16125/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestHiveMetastoreIntegration.java@a32 PS3, Line 32: > not sure, this was in Grant's initial WIP patch, readded it and modified it We don't need to validate the HMS integration Java side now. It has nothing to do with the Java client and results in an extra HMS dependency. Instead we should, and do, validate the HMS integration in the C++ server code. -- To view, visit http://gerrit.cloudera.org:8080/16125 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I083ad9750ce1b3ae31bb510b700d1204fcdf291d Gerrit-Change-Number: 16125 Gerrit-PatchSet: 4 Gerrit-Owner: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Greg Solovyev <gsolov...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 06 Jul 2020 13:01:04 +0000 Gerrit-HasComments: Yes
