Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16137 )
Change subject: Optimize GetTableLocations for better arena use ...................................................................... Patch Set 7: Code-Review+1 (2 comments) Looks good to me, just a few nits. http://gerrit.cloudera.org:8080/#/c/16137/7/src/kudu/master/master_service.cc File src/kudu/master/master_service.cc: http://gerrit.cloudera.org:8080/#/c/16137/7/src/kudu/master/master_service.cc@408 PS7, Line 408: AddAllocated If keeping the CHECK() above, does it make sense to switch to UnsafeArenaAddAllocated() here? Alternatively, maybe switch CHECK_EQ() into DCHECK_EQ() since AddAllocated() performs similar validation on itself and do copying if the arenas are different? http://gerrit.cloudera.org:8080/#/c/16137/7/src/kudu/master/ts_descriptor.cc File src/kudu/master/ts_descriptor.cc: http://gerrit.cloudera.org:8080/#/c/16137/7/src/kudu/master/ts_descriptor.cc@220 PS7, Line 220: CHECK nit: I guess if registration is an empty std::unique_ptr wrapper, the process will get a SIGSEGV at line 221. With that, do you think having DCHECK() is good enough here? -- To view, visit http://gerrit.cloudera.org:8080/16137 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I65aa6b5a9854a4659d1e350e1461ad63c03d5fea Gerrit-Change-Number: 16137 Gerrit-PatchSet: 7 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 07 Jul 2020 23:05:11 +0000 Gerrit-HasComments: Yes
