Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16137 )
Change subject: Optimize GetTableLocations for better arena use ...................................................................... Patch Set 7: -Code-Review Whoops, forgot to mention one issue with TSInfosDict. TSInfosDict is also used in AutoRebalancerTask::GetTabletLeader() (see auto_rebalancer.cc), so that dance with STLDeleteElements is necessary there as well. From the other side, maybe it's worth introducing an additional constructor for TSInfosDict or an additional class for TSInfosDict to be used outside of the CatalogManager. That class would store the heap-allocated elements of TSInfoPB wrapped into std::unique_ptr or call STLDeleteElements in the destructor. TSInfosDict's constructor should be made private, and CatalogManager and Master should be friended to use it. -- To view, visit http://gerrit.cloudera.org:8080/16137 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I65aa6b5a9854a4659d1e350e1461ad63c03d5fea Gerrit-Change-Number: 16137 Gerrit-PatchSet: 7 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 07 Jul 2020 23:13:32 +0000 Gerrit-HasComments: No
