Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16137 )
Change subject: Optimize GetTableLocations for better arena use ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/16137/7/src/kudu/master/ts_descriptor.cc File src/kudu/master/ts_descriptor.cc: http://gerrit.cloudera.org:8080/#/c/16137/7/src/kudu/master/ts_descriptor.cc@220 PS7, Line 220: CHECK > What's the benefit crashing with SIGABRT vs SIGSEGV? A better reputation o It's not about SIGABRT vs SIGSEGV, IIRC it's easier to debug CHECK failures as that will leave a log message while SIGSEGV will only leave a stack trace and a minidump and you need gdb and debug symbols to figure out why it crashed. I do agree that if this is a hot path and we have enough tests then it makes sense to only DCHECK though as in that case the benefits would likely not outweigh the costs. -- To view, visit http://gerrit.cloudera.org:8080/16137 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I65aa6b5a9854a4659d1e350e1461ad63c03d5fea Gerrit-Change-Number: 16137 Gerrit-PatchSet: 8 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 10 Jul 2020 22:03:55 +0000 Gerrit-HasComments: Yes
