Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16072 )
Change subject: KUDU-3090 Add ownership privileges ...................................................................... Patch Set 15: (4 comments) http://gerrit.cloudera.org:8080/#/c/16072/15/src/kudu/integration-tests/master_authz-itest.cc File src/kudu/integration-tests/master_authz-itest.cc: PS15: Can you also add a test for the case where a user gives its ownership away to another user and is then unable to access the table, while the other user can? http://gerrit.cloudera.org:8080/#/c/16072/15/src/kudu/integration-tests/master_authz-itest.cc@935 PS15, Line 935: t nit: capitalize and add a period http://gerrit.cloudera.org:8080/#/c/16072/15/src/kudu/integration-tests/master_authz-itest.cc@1063 PS15, Line 1063: string user; : if (std::get<2>(info.param) == kTestUser) { : user = "testuser"; : } else if (std::get<2>(info.param) == "{OWNER}") { : user = "owner"; : } nit: maybe be simpler as string user = kTestUser; if (std::get<2>(info.param) == "{OWNER}") { user = "owner"; } Same above http://gerrit.cloudera.org:8080/#/c/16072/15/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/16072/15/src/kudu/master/catalog_manager.cc@1978 PS15, Line 1978: if nit: capitalize this -- To view, visit http://gerrit.cloudera.org:8080/16072 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109 Gerrit-Change-Number: 16072 Gerrit-PatchSet: 15 Gerrit-Owner: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 08 Jul 2020 02:46:15 +0000 Gerrit-HasComments: Yes
