Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16072 )
Change subject: KUDU-3090 Add ownership privileges ...................................................................... Patch Set 16: (3 comments) http://gerrit.cloudera.org:8080/#/c/16072/15/src/kudu/integration-tests/master_authz-itest.cc File src/kudu/integration-tests/master_authz-itest.cc: PS15: > Can you also add a test for the case where a user gives its ownership away Done http://gerrit.cloudera.org:8080/#/c/16072/15/src/kudu/integration-tests/master_authz-itest.cc@935 PS15, Line 935: & > nit: capitalize and add a period Done http://gerrit.cloudera.org:8080/#/c/16072/15/src/kudu/integration-tests/master_authz-itest.cc@1063 PS15, Line 1063: : { : { : &MasterAuthzITestBase::IsAlterTableDone, : &MasterAuthzITestBase::GrantGetMetadataTablePrivilege, : "IsAlterTableDone", > nit: maybe be simpler as Unfortunately that doesn't work, kTestUser contains a hyphen which is an invalid character. Another option would be to change the value of kTestUser but I wasn't sure if I should touch it. -- To view, visit http://gerrit.cloudera.org:8080/16072 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109 Gerrit-Change-Number: 16072 Gerrit-PatchSet: 16 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 08 Jul 2020 12:17:08 +0000 Gerrit-HasComments: Yes
