Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/16147 )
Change subject: KUDU-636. Use protobuf arenas for CommitMsgs ...................................................................... Patch Set 3: (2 comments) think I fixed the issues but we'll see what the tests have to say http://gerrit.cloudera.org:8080/#/c/16147/2/src/kudu/consensus/log.h File src/kudu/consensus/log.h: http://gerrit.cloudera.org:8080/#/c/16147/2/src/kudu/consensus/log.h@591 PS2, Line 591: > What if replicate_op_ids_ is empty? Maybe, add a CHECK() on this pre-condi turns out this function was never even called, so i removed it http://gerrit.cloudera.org:8080/#/c/16147/2/src/kudu/tablet/ops/write_op.cc File src/kudu/tablet/ops/write_op.cc: http://gerrit.cloudera.org:8080/#/c/16147/2/src/kudu/tablet/ops/write_op.cc@243 PS2, Line 243: > nit: trailing space Done -- To view, visit http://gerrit.cloudera.org:8080/16147 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I78698d4cb4944bddd8dabd6cbbf1e3a064056199 Gerrit-Change-Number: 16147 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 09 Jul 2020 19:42:04 +0000 Gerrit-HasComments: Yes
