Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16124 )
Change subject: KUDU-2612 p4: mechanism to create a transaction status table ...................................................................... Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/16124/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16124/4//COMMIT_MSG@14 PS4, Line 14: kudu_system Should we enforce that all non-user tables are under this namespace? http://gerrit.cloudera.org:8080/#/c/16124/4/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/16124/4/src/kudu/master/catalog_manager.cc@1531 PS4, Line 1531: if (user && !req.has_owner()) { Would we still want this for system tables? Then the owner would be the kudu service user right? If we did that, we could require ownership as a way of enforcing only Kudu can write/modify the table. http://gerrit.cloudera.org:8080/#/c/16124/4/src/kudu/master/catalog_manager.cc@1540 PS4, Line 1540: for (int i = 0; i < req.schema().columns_size(); i++) { Why don't system tables need this? http://gerrit.cloudera.org:8080/#/c/16124/4/src/kudu/master/catalog_manager.cc@1559 PS4, Line 1559: // TODO(awong): only allow the service user to do this. Are you planning to do this in a follow on commit? Would it be easy enough to enforce requiring a superuser temporarily as opposed to being completely open? With this commit system tables will show up in list table commands and potentially attempted to be backed up and restored with backup jobs. -- To view, visit http://gerrit.cloudera.org:8080/16124 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I29b9009fa228a7749295b50516991613a28d58fa Gerrit-Change-Number: 16124 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 15 Jul 2020 14:39:02 +0000 Gerrit-HasComments: Yes
