Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16124 )
Change subject: KUDU-2612 p4: mechanism to create a transaction status table ...................................................................... Patch Set 8: (6 comments) http://gerrit.cloudera.org:8080/#/c/16124/8/src/kudu/integration-tests/master_authz-itest.cc File src/kudu/integration-tests/master_authz-itest.cc: http://gerrit.cloudera.org:8080/#/c/16124/8/src/kudu/integration-tests/master_authz-itest.cc@685 PS8, Line 685: kAdminUser Does it make sense to add a scenario when such a call is performed using other than admin user's creds? http://gerrit.cloudera.org:8080/#/c/16124/8/src/kudu/integration-tests/txn_status_table-itest.cc File src/kudu/integration-tests/txn_status_table-itest.cc: http://gerrit.cloudera.org:8080/#/c/16124/8/src/kudu/integration-tests/txn_status_table-itest.cc@152 PS8, Line 152: table What about KuduClient::TableExists() and KuduClient::GetTableSchema()? Does it make sense to cover those methods as well? http://gerrit.cloudera.org:8080/#/c/16124/8/src/kudu/integration-tests/txn_status_table-itest.cc@279 PS8, Line 279: creation nit: creation of ? http://gerrit.cloudera.org:8080/#/c/16124/8/src/kudu/transactions/txn_system_client.h File src/kudu/transactions/txn_system_client.h: http://gerrit.cloudera.org:8080/#/c/16124/8/src/kudu/transactions/txn_system_client.h@43 PS8, Line 43: static Status Create(const std::vector<std::string>& master_addrs, : std::unique_ptr<TxnSystemClient>* sys_client); : static Status CreateTxnStatusTableWithClient(int64_t initial_upper_bound, : client::KuduClient* client); : static Status AddTxnStatusTableRangeWithClient(int64_t lower_bound, int64_t upper_bound, : client::KuduClient* client); Do you mind adding a comment on the idea behind exposing these methods as public ones given there are non-static counterparts as well? http://gerrit.cloudera.org:8080/#/c/16124/8/src/kudu/transactions/txn_system_client.h@57 PS8, Line 57: AddTxnStatusTableRange What about dropping transaction status table range? What component is going to provide such a functionality? http://gerrit.cloudera.org:8080/#/c/16124/8/src/kudu/transactions/txn_system_client.cc File src/kudu/transactions/txn_system_client.cc: http://gerrit.cloudera.org:8080/#/c/16124/8/src/kudu/transactions/txn_system_client.cc@80 PS8, Line 80: 1 Is it really intended to be a non-replicated table? -- To view, visit http://gerrit.cloudera.org:8080/16124 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I29b9009fa228a7749295b50516991613a28d58fa Gerrit-Change-Number: 16124 Gerrit-PatchSet: 8 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 23 Jul 2020 05:43:04 +0000 Gerrit-HasComments: Yes
