Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16124 )
Change subject: KUDU-2612 p4: mechanism to create a transaction status table ...................................................................... Patch Set 9: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/16124/9/src/kudu/integration-tests/txn_status_table-itest.cc File src/kudu/integration-tests/txn_status_table-itest.cc: http://gerrit.cloudera.org:8080/#/c/16124/9/src/kudu/integration-tests/txn_status_table-itest.cc@162 PS9, Line 162: // While we prevent the table from being listed, clients should still be able : // to view it if it's explicitly asked for. Thank you for adding these. BTW, is that the behavior expected to be there long-term or you have plans to hide those tables from TableExists() and OpenTable() in the future? http://gerrit.cloudera.org:8080/#/c/16124/8/src/kudu/transactions/txn_system_client.h File src/kudu/transactions/txn_system_client.h: http://gerrit.cloudera.org:8080/#/c/16124/8/src/kudu/transactions/txn_system_client.h@57 PS8, Line 57: (awong): when we imple > It will likely live on the masters, since it seems easy enough to communica Thanks for the clarification: yep, this sounds good to me. -- To view, visit http://gerrit.cloudera.org:8080/16124 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I29b9009fa228a7749295b50516991613a28d58fa Gerrit-Change-Number: 16124 Gerrit-PatchSet: 9 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 24 Jul 2020 05:26:55 +0000 Gerrit-HasComments: Yes
