Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16124 )
Change subject: KUDU-2612 p4: mechanism to create a transaction status table ...................................................................... Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/16124/9/src/kudu/integration-tests/txn_status_table-itest.cc File src/kudu/integration-tests/txn_status_table-itest.cc: http://gerrit.cloudera.org:8080/#/c/16124/9/src/kudu/integration-tests/txn_status_table-itest.cc@162 PS9, Line 162: // While we prevent the table from being listed, clients should still be able : // to view it if it's explicitly asked for. > Thank you for adding these. I don't have strong opinions about this, so it'll probably be the long-term behavior. I don't see the harm in keeping it if a user explicitly asks for it. It'd be particularly surprising if a user tries to take the table name but it already exists, and then the user tried to call TableExists() and found that it didn't exist. I can imagine in the future we might also want a ListTable() variant that includes system tables, e.g. for health checks and checking skew and such. -- To view, visit http://gerrit.cloudera.org:8080/16124 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I29b9009fa228a7749295b50516991613a28d58fa Gerrit-Change-Number: 16124 Gerrit-PatchSet: 9 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 24 Jul 2020 07:07:02 +0000 Gerrit-HasComments: Yes
