Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16330 )
Change subject: KUDU-3181: put a bound on the queue of compilation manager ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/16330/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16330/2//COMMIT_MSG@9 PS2, Line 9: Using codegen_cache_capacity as max queue size. : You mentioned in the Jira that the end result you were looking for was a decrease in latent memory usage caused by an overflowed queue. Could you mention that here? http://gerrit.cloudera.org:8080/#/c/16330/2/src/kudu/codegen/compilation_manager.h File src/kudu/codegen/compilation_manager.h: http://gerrit.cloudera.org:8080/#/c/16330/2/src/kudu/codegen/compilation_manager.h@71 PS2, Line 71: // Otherwise, this enqueues a compilation task for the parameter : // schemas in the CompilationManager's thread pool and returns : // false. Upon any failure, false is returned. : // Does not write to 'out' if false is returned. nit: Can you update this comment a bit? What are the new failure semantics of this method? Can a request be rejected entirely now? Looking around, that doesn't seem like it'd be an issue because of the default RowProjector implementation. http://gerrit.cloudera.org:8080/#/c/16330/2/src/kudu/codegen/compilation_manager.cc File src/kudu/codegen/compilation_manager.cc: http://gerrit.cloudera.org:8080/#/c/16330/2/src/kudu/codegen/compilation_manager.cc@190 PS2, Line 190: if (!s.ok()) { : VLOG(1) << "RowProjector compilation request submit failed"; : } > I think WARN_NOT_OK_EVERY_N_SECS would be more appropriate here. +1 It'd be useful to see something logged by default, especially if it helps points us to the compilation manager pool being overwhelmed. -- To view, visit http://gerrit.cloudera.org:8080/16330 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia85b5818d1a5ea3ea978808900dd9c9e0cc0784e Gerrit-Change-Number: 16330 Gerrit-PatchSet: 2 Gerrit-Owner: Li Zhiming <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 12 Aug 2020 19:16:33 +0000 Gerrit-HasComments: Yes
