Li Zhiming has posted comments on this change. ( http://gerrit.cloudera.org:8080/16330 )
Change subject: KUDU-3181: put a bound on the queue of compilation manager ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/16330/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16330/2//COMMIT_MSG@7 PS2, Line 7: put a bound on the queue of compilation manager > Do you mind adding a test that set the maximum queue size to some very low A client test? No idea how to check the schedule state http://gerrit.cloudera.org:8080/#/c/16330/2/src/kudu/codegen/compilation_manager.cc File src/kudu/codegen/compilation_manager.cc: http://gerrit.cloudera.org:8080/#/c/16330/2/src/kudu/codegen/compilation_manager.cc@135 PS2, Line 135: FLAGS_codegen_cache_capacity > What's the reasoning to set the maximum queue size based on the capacity of Because the compilation result is not used by the current scan request, It must be stored in the cache for later use. If the cache capacity is 0, then the task should not be executed, since its result could not be stored in the cache for later use. Just no point for queue capacity be much greater than cache capacity. I agree that it would be cleaner to introduce a separate flag -- To view, visit http://gerrit.cloudera.org:8080/16330 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia85b5818d1a5ea3ea978808900dd9c9e0cc0784e Gerrit-Change-Number: 16330 Gerrit-PatchSet: 2 Gerrit-Owner: Li Zhiming <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Li Zhiming <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 13 Aug 2020 03:00:29 +0000 Gerrit-HasComments: Yes
