Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16330 )
Change subject: KUDU-3181: put a bound on the queue of compilation manager ...................................................................... Patch Set 4: Code-Review+1 (2 comments) Looks good to me, but there is also some feedback from Andrew to address. http://gerrit.cloudera.org:8080/#/c/16330/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16330/2//COMMIT_MSG@7 PS2, Line 7: put a bound on the queue of compilation manager > A client test? No idea how to check the schedule state Whoops, apparently, I expressed my thoughts not clear enough. I meant to have a test to verify that nothing is broken if severely limiting the maximum queue size for the compilation manager. However, it seems none of existing tests shows any regressions if setting that limit to at least to 100, so I guess it should be fine and current tests provide enough coverage. I think no test is needed then. http://gerrit.cloudera.org:8080/#/c/16330/2/src/kudu/codegen/compilation_manager.cc File src/kudu/codegen/compilation_manager.cc: http://gerrit.cloudera.org:8080/#/c/16330/2/src/kudu/codegen/compilation_manager.cc@135 PS2, Line 135: > Because the compilation result is not used by the current scan request, It Ah, I see: yes, your explanation makes sense. However, there is another factor involved: the timings and pattern of incoming requests. Anyways, introduction of a separate configuration parameter for the maximum queue size makes it's cleaner, thanks! -- To view, visit http://gerrit.cloudera.org:8080/16330 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia85b5818d1a5ea3ea978808900dd9c9e0cc0784e Gerrit-Change-Number: 16330 Gerrit-PatchSet: 4 Gerrit-Owner: Li Zhiming <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Li Zhiming <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 13 Aug 2020 22:03:00 +0000 Gerrit-HasComments: Yes
