Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15800 )
Change subject: KUDU-2844 (1/3): make BlockHandle ref-counted ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/15800/1/src/kudu/cfile/binary_dict_block.h File src/kudu/cfile/binary_dict_block.h: http://gerrit.cloudera.org:8080/#/c/15800/1/src/kudu/cfile/binary_dict_block.h@176 PS1, Line 176: scoped_refptr<BlockHandle> block_; > Why we do not use std::shared_ptr ? changed to use shared_ptr http://gerrit.cloudera.org:8080/#/c/15800/1/src/kudu/cfile/block_cache.h File src/kudu/cfile/block_cache.h: http://gerrit.cloudera.org:8080/#/c/15800/1/src/kudu/cfile/block_cache.h@196 PS1, Line 196: > nit: extra line? Done http://gerrit.cloudera.org:8080/#/c/15800/1/src/kudu/cfile/block_handle.h File src/kudu/cfile/block_handle.h: http://gerrit.cloudera.org:8080/#/c/15800/1/src/kudu/cfile/block_handle.h@22 PS1, Line 22: #include "kudu/gutil/ref_counted.h" > style nit: should this come after the 'boost' headers? Done http://gerrit.cloudera.org:8080/#/c/15800/1/src/kudu/cfile/block_handle.h@39 PS1, Line 39: > nit: extra space Done http://gerrit.cloudera.org:8080/#/c/15800/1/src/kudu/cfile/block_handle.h@64 PS1, Line 64: : boost::variant<BlockCacheHandle, scoped_refptr<BlockHandle>> ref_; : Slice data_; : bool is_data_owner_; : > nit: mind moving these below the methods? Done -- To view, visit http://gerrit.cloudera.org:8080/15800 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1077fcc841ca31a2cb523769fffeed2d27782bc1 Gerrit-Change-Number: 15800 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Volodymyr Verovkin <[email protected]> Gerrit-Comment-Date: Wed, 12 Aug 2020 21:29:37 +0000 Gerrit-HasComments: Yes
