Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15800 )
Change subject: KUDU-2844 (1/3): make BlockHandle ref-counted ...................................................................... Patch Set 2: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/15800/2/src/kudu/cfile/block_handle.h File src/kudu/cfile/block_handle.h: http://gerrit.cloudera.org:8080/#/c/15800/2/src/kudu/cfile/block_handle.h@94 PS2, Line 94: boost::variant<BlockCacheHandle, std::shared_ptr<BlockHandle>> ref_; Given how many block handlers we expect there to be in the lifespan of a server, might there be adverse caching effects in using shared_ptr<> over scoped_ptr<>? Or is the "only requires a single allocation, and ref count is on the same cache line as the object" mentioned here[1] fairly minor? [1] https://kudu.apache.org/docs/contributing.html#_pointers -- To view, visit http://gerrit.cloudera.org:8080/15800 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1077fcc841ca31a2cb523769fffeed2d27782bc1 Gerrit-Change-Number: 15800 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Volodymyr Verovkin <[email protected]> Gerrit-Comment-Date: Thu, 13 Aug 2020 05:06:20 +0000 Gerrit-HasComments: Yes
