Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15800 )
Change subject: KUDU-2844 (1/3): make BlockHandle ref-counted ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/15800/3/src/kudu/cfile/block_handle.h File src/kudu/cfile/block_handle.h: http://gerrit.cloudera.org:8080/#/c/15800/3/src/kudu/cfile/block_handle.h@23 PS3, Line 23: #include <boost/none.hpp> > nit: I'm surprised this was needed. Is it a remnant from before using Unini huh, not sure how it got there. will try removing :) http://gerrit.cloudera.org:8080/#/c/15800/3/src/kudu/cfile/block_handle.h@64 PS3, Line 64: for > nit: this Done -- To view, visit http://gerrit.cloudera.org:8080/15800 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1077fcc841ca31a2cb523769fffeed2d27782bc1 Gerrit-Change-Number: 15800 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <andrew.w...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Volodymyr Verovkin <verjov...@cloudera.com> Gerrit-Comment-Date: Thu, 13 Aug 2020 22:29:53 +0000 Gerrit-HasComments: Yes
