Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16332 )
Change subject: KUDU-1587 part 1: load meter for ThreadPool ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/16332/8/src/kudu/util/threadpool-test.cc File src/kudu/util/threadpool-test.cc: http://gerrit.cloudera.org:8080/#/c/16332/8/src/kudu/util/threadpool-test.cc@463 PS8, Line 463: // Test scenario to verify the functionality of the QueueLoadMeter. : TEST_F(ThreadPoolTest, QueueLoadMeter) { While the serial case may not be the focus of this series, since it's in this patch, can you add some test coverage for token-based submission? http://gerrit.cloudera.org:8080/#/c/16332/7/src/kudu/util/threadpool.cc File src/kudu/util/threadpool.cc: http://gerrit.cloudera.org:8080/#/c/16332/7/src/kudu/util/threadpool.cc@809 PS7, Line 809: // threadpool's activity, the queue might have stalled because all its worker : // threads have been busy for long time. If so, 'overloaded_since_' hasn't : // been updated by the activity on the thread pool itself. However, it's : / > Nope, I don't think it make sense to put this atop of the method. I see, thanks for explaining! It didn't connect for me at first that the initial check is only checking the overloaded state since the last insertion/removal from the queue. -- To view, visit http://gerrit.cloudera.org:8080/16332 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I640716dc32f193e68361ca623ee7b9271e661d8b Gerrit-Change-Number: 16332 Gerrit-PatchSet: 8 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Mon, 24 Aug 2020 19:34:58 +0000 Gerrit-HasComments: Yes
