Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16332 )
Change subject: KUDU-1587 part 1: load meter for ThreadPool ...................................................................... Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/16332/11/src/kudu/util/threadpool.cc File src/kudu/util/threadpool.cc: http://gerrit.cloudera.org:8080/#/c/16332/11/src/kudu/util/threadpool.cc@605 PS11, Line 605: // The uninitialized value of MonoTime for the next task to be run means : // it's an empty queue, so no task to be run. > This might be true if we had a guarantee that DispatchThreads() always find An update: this is necessary to as a notification on spare threads appearing. Without this piece, in some situations, a previously overloaded queue would be reported overloaded even after all tasks are complete. -- To view, visit http://gerrit.cloudera.org:8080/16332 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I640716dc32f193e68361ca623ee7b9271e661d8b Gerrit-Change-Number: 16332 Gerrit-PatchSet: 11 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 27 Aug 2020 06:29:47 +0000 Gerrit-HasComments: Yes
