Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16332 )
Change subject: KUDU-1587 part 1: load meter for ThreadPool ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/16332/8/src/kudu/util/threadpool-test.cc File src/kudu/util/threadpool-test.cc: http://gerrit.cloudera.org:8080/#/c/16332/8/src/kudu/util/threadpool-test.cc@463 PS8, Line 463: // Test scenario to verify the functionality of the QueueLoadMeter. : TEST_F(ThreadPoolTest, QueueLoadMeter) { > While the serial case may not be the focus of this series, since it's in th Good call. Done. http://gerrit.cloudera.org:8080/#/c/16332/8/src/kudu/util/threadpool.cc File src/kudu/util/threadpool.cc: http://gerrit.cloudera.org:8080/#/c/16332/8/src/kudu/util/threadpool.cc@301 PS8, Line 301: max_threads_ > What's the intuition behind using the max number of threads as the overload Nope, I don't think we need to have some tunable parameter for that. I think max_threads gives us the proper setting for the history size given our criterion on the overloaded state (where N is the size of the queue time history): max(QT_head, min(QT_historic(N))) > T_overload I added an extra paragraph about this into the class-wide comment for QueueLoadMeter. -- To view, visit http://gerrit.cloudera.org:8080/16332 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I640716dc32f193e68361ca623ee7b9271e661d8b Gerrit-Change-Number: 16332 Gerrit-PatchSet: 8 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 25 Aug 2020 21:20:48 +0000 Gerrit-HasComments: Yes
