Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16372 )
Change subject: Fix C++ client API docs ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/16372/1/src/kudu/client/scan_batch.h File src/kudu/client/scan_batch.h: http://gerrit.cloudera.org:8080/#/c/16372/1/src/kudu/client/scan_batch.h@a211 PS1, Line 211: We lose a bit of "documentation" here given I think this was the only place we described what the unit of the value was. Maybe this needs it's own documentation block? http://gerrit.cloudera.org:8080/#/c/16372/1/src/kudu/common/partial_row.h File src/kudu/common/partial_row.h: http://gerrit.cloudera.org:8080/#/c/16372/1/src/kudu/common/partial_row.h@a111 PS1, Line 111: : : : Same as my comment in scan_batch. http://gerrit.cloudera.org:8080/#/c/16372/1/src/kudu/common/partial_row.h@a452 PS1, Line 452: : : Same as my comment in scan_batch. -- To view, visit http://gerrit.cloudera.org:8080/16372 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I387be394d656a7614189148a39ff7dec76eb994d Gerrit-Change-Number: 16372 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 26 Aug 2020 13:51:39 +0000 Gerrit-HasComments: Yes
