Attila Bukor has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16372 )

Change subject: Fix C++ client API docs
......................................................................


Patch Set 4:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/16372/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/16372/3//COMMIT_MSG@29
PS3, Line 29: I5eddf689da90123ca52075d09de07981d11f8ffe
> nit: I guess it's better to use githash while referencing changelists
I agree, however, this change isn't committed yet, so the commit hash will 
still change.


http://gerrit.cloudera.org:8080/#/c/16372/2/src/kudu/client/client.h
File src/kudu/client/client.h:

http://gerrit.cloudera.org:8080/#/c/16372/2/src/kudu/client/client.h@1173
PS2, Line 1173:   /// @warning Unstable API
              :   ///
> While you are at this, maybe move the method above under this Advanced/Unst
Done



--
To view, visit http://gerrit.cloudera.org:8080/16372
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I387be394d656a7614189148a39ff7dec76eb994d
Gerrit-Change-Number: 16372
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <abu...@apache.org>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <abu...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com>
Gerrit-Reviewer: Grant Henke <granthe...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 26 Aug 2020 18:13:35 +0000
Gerrit-HasComments: Yes

Reply via email to