Hello Alexey Serbin, Kudu Jenkins, Grant Henke, Bankim Bhavsar,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16372
to look at the new patch set (#4).
Change subject: Fix C++ client API docs
......................................................................
Fix C++ client API docs
This patch fixes C++ API doxygen comments so the build succeeds. It's
unclear when this broke exactly.
Running docs/support/scripts/make_site.sh with Doxygen 1.8.11 failed
with the below warning:
util/monotime.h:371: error: argument 'lhs' of command @param is not found in
the argument list of kudu::MonoDelta::operator+(const MonoDelta &, const
MonoDelta &) (warning treated as error, aborting now)
When Kudu 1.12.0 was released, the docs were generated with Doxygen
1.8.11, although it's possible that treating warnings as errors was
disabled for the release to work around this issue.
After upgrading to Doxygen 1.8.15 this warning disappeared, but a
different one surfaced:
common/partial_row.h:105: error: Member SetBool(const Slice &col_name, bool
val) WARN_UNUSED_RESULT (function) of class KuduPartialRow is not documented.
(warning treated as error, aborting now)
I disabled WARN_AS_ERROR temporarily only to discover several other
warnings. Some of them were due to Doxygen bugs solved by another update
to 1.8.19 in an earlier commit (change ID:
I5eddf689da90123ca52075d09de07981d11f8ffe), the rest manually by this
commit.
Change-Id: I387be394d656a7614189148a39ff7dec76eb994d
---
M src/kudu/client/client.h
M src/kudu/client/scan_batch.cc
M src/kudu/client/scan_batch.h
M src/kudu/client/schema.h
M src/kudu/client/value.h
M src/kudu/common/partial_row.cc
M src/kudu/common/partial_row.h
M src/kudu/util/monotime.h
M src/kudu/util/status.h
9 files changed, 268 insertions(+), 161 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/72/16372/4
--
To view, visit http://gerrit.cloudera.org:8080/16372
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I387be394d656a7614189148a39ff7dec76eb994d
Gerrit-Change-Number: 16372
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <abu...@apache.org>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <abu...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com>
Gerrit-Reviewer: Grant Henke <granthe...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
