Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16364 )
Change subject: [net] KUDU-3184: Fix GetFQDN() when canonical name returns null ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/16364/5/src/kudu/util/net/net_util.cc File src/kudu/util/net/net_util.cc: http://gerrit.cloudera.org:8080/#/c/16364/5/src/kudu/util/net/net_util.cc@418 PS5, Line 418: result->ai_canonname != nullptr > I would have to test that but hostname should match the FQDN when the canon Yep, that makes sense. If you find that the best option is returning Status::OK() when result->ai_canonname is nullptr, maybe at least update the in-line doc/comment for this function in net_util.h to document the new behavior. Thanks! -- To view, visit http://gerrit.cloudera.org:8080/16364 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6bfc1a39175761e3a2f19280066cb1c8343fe79d Gerrit-Change-Number: 16364 Gerrit-PatchSet: 5 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 27 Aug 2020 15:13:52 +0000 Gerrit-HasComments: Yes
