Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16364 )
Change subject: [net] KUDU-3184: Fix GetFQDN() when canonical name returns null ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/16364/5/src/kudu/util/net/net_util.cc File src/kudu/util/net/net_util.cc: http://gerrit.cloudera.org:8080/#/c/16364/5/src/kudu/util/net/net_util.cc@418 PS5, Line 418: result->ai_canonname != nullptr > Should we return non-OK status if esult->ai_canonname == nullptr? In the case that the canonical name is null it's my understanding that FQDN doesn't have a domain name. The call on line 404 to GetHostname would return the hostname which in this case is same as FQDN since there's no domain name. Therefore, even if the canonical name was null, hostname would already be the FQDN. -- To view, visit http://gerrit.cloudera.org:8080/16364 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6bfc1a39175761e3a2f19280066cb1c8343fe79d Gerrit-Change-Number: 16364 Gerrit-PatchSet: 5 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 26 Aug 2020 23:46:13 +0000 Gerrit-HasComments: Yes
