Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16364 )

Change subject: KUDU-3184:[net] Fix GetFQDN() when canonical name returns null
......................................................................


Patch Set 4: Code-Review+1

(2 comments)

http://gerrit.cloudera.org:8080/#/c/16364/4//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/16364/4//COMMIT_MSG@7
PS4, Line 7: :[net]
nit: add a space, e.g.

 [net] KUDU-3184: fix GetFQDN() when...


http://gerrit.cloudera.org:8080/#/c/16364/4//COMMIT_MSG@7
PS4, Line 7: KUDU-3184
For future reference, it'd be nice if you could add more details to the ticket 
or the commit message for a fix. For instance, it seems unlikely that every 
failure to startup a Master (i.e. "Unable to start Master at index 0") is 
caused by this issue. Through debugging, there were probably some stack traces 
you found that could have been included that would help other users determine 
whether they hit this same issue vs some other Master failure.



--
To view, visit http://gerrit.cloudera.org:8080/16364
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6bfc1a39175761e3a2f19280066cb1c8343fe79d
Gerrit-Change-Number: 16364
Gerrit-PatchSet: 4
Gerrit-Owner: Mahesh Reddy <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Bankim Bhavsar <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <[email protected]>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Wed, 26 Aug 2020 19:09:57 +0000
Gerrit-HasComments: Yes

Reply via email to