Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16403 )
Change subject: KUDU-2574: Add a unique cluster ID ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/16403/2/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/16403/2/src/kudu/master/catalog_manager.cc@910 PS2, Line 910: > Nit: extra space. Done http://gerrit.cloudera.org:8080/#/c/16403/2/src/kudu/master/catalog_manager.cc@1042 PS2, Line 1042: *cluster_id = entry.cluster_id(); > Debug check for entry.has_cluster_id() since it's optional? GetClusterIdEntry has that check already. http://gerrit.cloudera.org:8080/#/c/16403/2/src/kudu/master/master.h File src/kudu/master/master.h: http://gerrit.cloudera.org:8080/#/c/16403/2/src/kudu/master/master.h@78 PS2, Line 78: std::string > nit: Return a const reference instead of a copy. Done -- To view, visit http://gerrit.cloudera.org:8080/16403 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4df1d3f7d100336f52563f3008cacf6d9e328fae Gerrit-Change-Number: 16403 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 02 Sep 2020 18:48:25 +0000 Gerrit-HasComments: Yes
