Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16403 )
Change subject: KUDU-2574: Add a unique cluster ID ...................................................................... Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/16403/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16403/3//COMMIT_MSG@9 PS3, Line 9: uniquie unique http://gerrit.cloudera.org:8080/#/c/16403/3/src/kudu/master/catalog_manager.h File src/kudu/master/catalog_manager.h: http://gerrit.cloudera.org:8080/#/c/16403/3/src/kudu/master/catalog_manager.h@903 PS3, Line 903: InitClusterID nit: InitClusterId() to be consistent with other method names http://gerrit.cloudera.org:8080/#/c/16403/3/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/16403/3/src/kudu/master/catalog_manager.cc@903 PS3, Line 903: cluster_id = oid_generator.Next(); Could we use GenerateId() here? http://gerrit.cloudera.org:8080/#/c/16403/3/src/kudu/master/sys_catalog-test.cc File src/kudu/master/sys_catalog-test.cc: PS3: Could you also add a test that we get the same uuid when we restart a master, and when a new master leader is elected? http://gerrit.cloudera.org:8080/#/c/16403/3/src/kudu/master/sys_catalog.cc File src/kudu/master/sys_catalog.cc: http://gerrit.cloudera.org:8080/#/c/16403/3/src/kudu/master/sys_catalog.cc@761 PS3, Line 761: entries.front().Swap(entry); nit: might be clearer as *entry = std::move(entries[0]); -- To view, visit http://gerrit.cloudera.org:8080/16403 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4df1d3f7d100336f52563f3008cacf6d9e328fae Gerrit-Change-Number: 16403 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 02 Sep 2020 18:52:54 +0000 Gerrit-HasComments: Yes
