Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16401 )
Change subject: [util] add performance test scenario for ThreadPool ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/16401/2/src/kudu/util/threadpool-test.cc File src/kudu/util/threadpool-test.cc: http://gerrit.cloudera.org:8080/#/c/16401/2/src/kudu/util/threadpool-test.cc@736 PS2, Line 736: const auto kQueueTimeThreshold = MonoDelta::FromMilliseconds(100); Is the motivation of this patch to determine a good default value for this? Or is the queue time threshold not important to throughput in the context of this test? http://gerrit.cloudera.org:8080/#/c/16401/2/src/kudu/util/threadpool-test.cc@762 PS2, Line 762: if (i % 100 == 0) { : SleepFor(MonoDelta::FromMicroseconds(1)); : } Does this sleep make a noticeable difference on the throughputs reported by this test? -- To view, visit http://gerrit.cloudera.org:8080/16401 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I470d204f3b3a22407361a920882a93d6f21dd274 Gerrit-Change-Number: 16401 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 02 Sep 2020 19:32:21 +0000 Gerrit-HasComments: Yes
