Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16401 )
Change subject: [util] add performance test scenario for ThreadPool ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/16401/2/src/kudu/util/threadpool-test.cc File src/kudu/util/threadpool-test.cc: http://gerrit.cloudera.org:8080/#/c/16401/2/src/kudu/util/threadpool-test.cc@736 PS2, Line 736: const auto kQueueTimeThreshold = MonoDelta::FromMilliseconds(100); > Is the motivation of this patch to determine a good default value for this? It's just some value to set; it's important. The only thought was to have a threshold that most likely lead to detecting queue overload status. http://gerrit.cloudera.org:8080/#/c/16401/2/src/kudu/util/threadpool-test.cc@762 PS2, Line 762: if (i % 100 == 0) { : SleepFor(MonoDelta::FromMicroseconds(1)); : } > Does this sleep make a noticeable difference on the throughputs reported by It doesn't make a noticeable difference in the throughput, but I think it makes the scenario a bit closer to the real world scenarios: no real task usually just schedules thousands of tasks without doing some other work in the middle. -- To view, visit http://gerrit.cloudera.org:8080/16401 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I470d204f3b3a22407361a920882a93d6f21dd274 Gerrit-Change-Number: 16401 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 03 Sep 2020 00:32:24 +0000 Gerrit-HasComments: Yes
