Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16401 )
Change subject: [util] add performance test scenario for ThreadPool ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/16401/2/src/kudu/util/threadpool-test.cc File src/kudu/util/threadpool-test.cc: http://gerrit.cloudera.org:8080/#/c/16401/2/src/kudu/util/threadpool-test.cc@762 PS2, Line 762: for (auto i = 0; i < kNumTasksPerSchedulerThread; ++i) { : CHECK_OK(token->Submit([](){})); : } > It doesn't make a noticeable difference in the throughput, but I think it m After playing with that a couple more times, I removed this. The idea was to have a scenario closer to real ones and induce some irregularities in growing and shrinking the queue, but it's not crucial in the scope of this benchmark. http://gerrit.cloudera.org:8080/#/c/16401/3/src/kudu/util/threadpool-test.cc File src/kudu/util/threadpool-test.cc: http://gerrit.cloudera.org:8080/#/c/16401/3/src/kudu/util/threadpool-test.cc@737 PS3, Line 737: t > nit: enough Done -- To view, visit http://gerrit.cloudera.org:8080/16401 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I470d204f3b3a22407361a920882a93d6f21dd274 Gerrit-Change-Number: 16401 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 03 Sep 2020 20:01:04 +0000 Gerrit-HasComments: Yes
