Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16400 )
Change subject: KUDU-3012: Log Throttler ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/16400/1/java/kudu-client/src/main/java/org/apache/kudu/util/ThrottlerLogUtil.java File java/kudu-client/src/main/java/org/apache/kudu/util/ThrottlerLogUtil.java: http://gerrit.cloudera.org:8080/#/c/16400/1/java/kudu-client/src/main/java/org/apache/kudu/util/ThrottlerLogUtil.java@63 PS1, Line 63: processing(seconds, msg) > Among the throttle log implementations I've used in the past, don't recall Another thought I had was to instead have each ThrottlerLogUtil instance only keep track of a single lastLoggedTimestamp at a time, and circumvent hashing or message/key tracking entirely. The onus is already on the caller to define where they want to throttle in their application. If that's the case, it doesn't seem like much effort for developers to define new ThrottlerLogUtil instances per instance of throttling. In general, my concern is around throttling messages that are not fixed constants. In such cases, message-based throttling doesn't make sense while also being computationally expensive on account of the frequent hashing. -- To view, visit http://gerrit.cloudera.org:8080/16400 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia2089b6fc905a5b54d664b7200060cabb965f40f Gerrit-Change-Number: 16400 Gerrit-PatchSet: 1 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Wed, 02 Sep 2020 22:09:10 +0000 Gerrit-HasComments: Yes
