Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16400 )
Change subject: KUDU-3012: Add a Log Throttler ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/16400/3/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java: http://gerrit.cloudera.org:8080/#/c/16400/3/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java@118 PS3, Line 118: final > Should this be static? then multiple instances of AsyncKuduSession will share the same throttler and manipulate the same copy of the lastLoggedTime variable, will leave it as is for now unless anyone has any objections http://gerrit.cloudera.org:8080/#/c/16400/2/java/kudu-client/src/test/java/org/apache/kudu/util/TestLogThrottler.java File java/kudu-client/src/test/java/org/apache/kudu/util/TestLogThrottler.java: http://gerrit.cloudera.org:8080/#/c/16400/2/java/kudu-client/src/test/java/org/apache/kudu/util/TestLogThrottler.java@46 PS2, Line 46: : > Alternatively, you can only throttle 10 messages. Done -- To view, visit http://gerrit.cloudera.org:8080/16400 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia2089b6fc905a5b54d664b7200060cabb965f40f Gerrit-Change-Number: 16400 Gerrit-PatchSet: 3 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Thu, 03 Sep 2020 21:26:56 +0000 Gerrit-HasComments: Yes
