Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16400 )
Change subject: KUDU-3012: Add a Log Throttler ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/16400/2/java/kudu-client/src/main/java/org/apache/kudu/util/ThrottlerLogUtil.java File java/kudu-client/src/main/java/org/apache/kudu/util/ThrottlerLogUtil.java: http://gerrit.cloudera.org:8080/#/c/16400/2/java/kudu-client/src/main/java/org/apache/kudu/util/ThrottlerLogUtil.java@42 PS2, Line 42: ThrottlerLogUtil > nit: Maybe name this "LogThrottler" now that it's not a utility class? Done http://gerrit.cloudera.org:8080/#/c/16400/2/java/kudu-client/src/test/java/org/apache/kudu/util/TestLogThrottler.java File java/kudu-client/src/test/java/org/apache/kudu/util/TestLogThrottler.java: http://gerrit.cloudera.org:8080/#/c/16400/2/java/kudu-client/src/test/java/org/apache/kudu/util/TestLogThrottler.java@46 PS2, Line 46: : > nothing really, I can remove it actually the colon or any character is necessary after i because if I remove it, the test will fail because "Logging 5" is seen as a part of "Logging 51" without the colon and that would fail the assertFalse statement as only "Logging 51" should be logged while "Logging 5" shouldn't be logged. http://gerrit.cloudera.org:8080/#/c/16400/2/java/kudu-client/src/test/java/org/apache/kudu/util/TestLogThrottler.java@56 PS2, Line 56: > hm but checkstyle didnt complain? it's a continuation of the previous line Done -- To view, visit http://gerrit.cloudera.org:8080/16400 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia2089b6fc905a5b54d664b7200060cabb965f40f Gerrit-Change-Number: 16400 Gerrit-PatchSet: 2 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Thu, 03 Sep 2020 18:22:43 +0000 Gerrit-HasComments: Yes
