Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16510 )
Change subject: KUDU-2612: have MRS iteration account for txn metadata ...................................................................... Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/16510/3/src/kudu/tablet/memrowset.cc File src/kudu/tablet/memrowset.cc: http://gerrit.cloudera.org:8080/#/c/16510/3/src/kudu/tablet/memrowset.cc@128 PS3, Line 128: txn_id_(txn_id), > warning: std::move of the variable 'txn_id' of the trivially-copyable type Done http://gerrit.cloudera.org:8080/#/c/16510/3/src/kudu/tablet/mvcc-test.cc File src/kudu/tablet/mvcc-test.cc: http://gerrit.cloudera.org:8080/#/c/16510/3/src/kudu/tablet/mvcc-test.cc@817 PS3, Line 817: void AbortBeforeBeginCommit(TxnMetadata* txn_meta) { > warning: method 'AbortBeforeBeginCommit' can be made static [readability-co Done http://gerrit.cloudera.org:8080/#/c/16510/3/src/kudu/tablet/mvcc-test.cc@887 PS3, Line 887: enum OpType { > warning: invalid case style for enum 'kOp' [readability-identifier-naming] Done http://gerrit.cloudera.org:8080/#/c/16510/3/src/kudu/tablet/mvcc.cc File src/kudu/tablet/mvcc.cc: http://gerrit.cloudera.org:8080/#/c/16510/3/src/kudu/tablet/mvcc.cc@49 PS3, Line 49: > warning: using decl 'map' is unused [misc-unused-using-decls] Done -- To view, visit http://gerrit.cloudera.org:8080/16510 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6bb02c6025eea1a327cf9d9ee1f14a38d63ae4ad Gerrit-Change-Number: 16510 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 09 Oct 2020 00:32:50 +0000 Gerrit-HasComments: Yes
