Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16510 )
Change subject: KUDU-2612: have MRS iteration account for txn metadata ...................................................................... Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/16510/6/src/kudu/tablet/memrowset-test.cc File src/kudu/tablet/memrowset-test.cc: http://gerrit.cloudera.org:8080/#/c/16510/6/src/kudu/tablet/memrowset-test.cc@958 PS6, Line 958: how we iterate Does it make sense to add coverage for CheckRowsBetween() in between latest_with_none_applied, latest_with_one_applied and latest_with_two_applied? http://gerrit.cloudera.org:8080/#/c/16510/6/src/kudu/tablet/memrowset-test.cc@999 PS6, Line 999: how we iterate Ditto: what about CheckRowsBetween() in between latest_with_none_applied, latest_with_one_applied and latest_with_two_applied and snap_{after,before}_begin_commit, latest_after_begin_commit ? http://gerrit.cloudera.org:8080/#/c/16510/6/src/kudu/tablet/mvcc-test.cc File src/kudu/tablet/mvcc-test.cc: http://gerrit.cloudera.org:8080/#/c/16510/6/src/kudu/tablet/mvcc-test.cc@787 PS6, Line 787: class TransactionMvccTest : public MvccTest { > Looking at the set of added test scenarios I'm curious whether we have enou Ah, I guess the coverage for different types of snapshots is provided by the newly added tests in src/kudu/tablet/memrowset-test.cc -- To view, visit http://gerrit.cloudera.org:8080/16510 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6bb02c6025eea1a327cf9d9ee1f14a38d63ae4ad Gerrit-Change-Number: 16510 Gerrit-PatchSet: 6 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 20 Oct 2020 06:23:54 +0000 Gerrit-HasComments: Yes
