Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16658 )
Change subject: Increase key size in tests and EMC ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/16658/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16658/3//COMMIT_MSG@11 PS3, Line 11: This commit removes the test-only key size Given that the majority of Kudu test runs (pre-commit, benchmarks, etc.) are run non-FIPS enabled environment, I don't think it makes sense to have this blanket-style solution. What does it buy us besides making these tests pass in a FIPS-enabled environment, which is once-in-a-while manual run? Instead, I'd rather vote for bumping up key size only if some special variable is provided, something similar to KUDU_ALLOW_SLOW_TESTS. http://gerrit.cloudera.org:8080/#/c/16658/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16658/4//COMMIT_MSG@10 PS4, Line 10: these tests In addition to these tests, did you try to run Java tests as well? I remember we did some tweaks to default Java security policies in java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/MiniKuduCluster.java I'm just curious whether FIPS-enabled mode somehow affects the Java (client) side as well given we added those tweaks. -- To view, visit http://gerrit.cloudera.org:8080/16658 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45b96e0b4499ea1d80db5871a529c732ad41220e Gerrit-Change-Number: 16658 Gerrit-PatchSet: 4 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Tue, 27 Oct 2020 18:33:45 +0000 Gerrit-HasComments: Yes
