Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16658 )
Change subject: Increase key size in tests and EMC ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/16658/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16658/3//COMMIT_MSG@11 PS3, Line 11: This commit removes the test-only key size > Grant and I were discussing more regular, potentially even pre-commit build As I understand, adding a gate like KUDU_ALLOW_SLOW_TESTS would allow to run pre-commit builds in FIPS-approved or whatever environment is, so it wouldn't hurt. And as you mentioned, running test with different key length might show potential issues, so adding a gate for different key length is a win-win, IMO. http://gerrit.cloudera.org:8080/#/c/16658/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16658/4//COMMIT_MSG@10 PS4, Line 10: these tests > I did, all tests passed even with this added to tests.gradle: Cool! Why not to include those changes for tests.gradle in this changelist as well? -- To view, visit http://gerrit.cloudera.org:8080/16658 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45b96e0b4499ea1d80db5871a529c732ad41220e Gerrit-Change-Number: 16658 Gerrit-PatchSet: 4 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 28 Oct 2020 19:09:14 +0000 Gerrit-HasComments: Yes
