Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16698 )
Change subject: KUDU-1563. Add a feature flag for IGNORE operations ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/16698/3/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java: http://gerrit.cloudera.org:8080/#/c/16698/3/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@2662 PS3, Line 2662: // The server returns an RpcRemoteException when : // the required feature is not supported. : if (resp instanceof RpcRemoteException) { : return false; : } > Does it make sense to be more specific here? As I understand, the server s Done http://gerrit.cloudera.org:8080/#/c/16698/3/java/kudu-client/src/main/java/org/apache/kudu/client/PingRequest.java File java/kudu-client/src/main/java/org/apache/kudu/client/PingRequest.java: http://gerrit.cloudera.org:8080/#/c/16698/3/java/kudu-client/src/main/java/org/apache/kudu/client/PingRequest.java@43 PS3, Line 43: makeMasterPingRequest > I don't have good understanding of exact workflow here, but would it be mor It's not something that is done or required at connection time or could even be set at connection time. If you look at the follow on patches it is only used in certain use cases and runtime for an application. http://gerrit.cloudera.org:8080/#/c/16698/3/src/kudu/master/master_service.cc File src/kudu/master/master_service.cc: http://gerrit.cloudera.org:8080/#/c/16698/3/src/kudu/master/master_service.cc@106 PS3, Line 106: TAG_FLAG > nit: does it make sense to add the 'runtime' tag as well? Done -- To view, visit http://gerrit.cloudera.org:8080/16698 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I329bd8bde73d247240ae597b677e2cc20a92343a Gerrit-Change-Number: 16698 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sat, 07 Nov 2020 03:33:42 +0000 Gerrit-HasComments: Yes
