Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16698 )

Change subject: KUDU-1563. Add a feature flag for IGNORE operations
......................................................................


Patch Set 4: Code-Review+2

(2 comments)

http://gerrit.cloudera.org:8080/#/c/16698/4//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/16698/4//COMMIT_MSG@17
PS4, Line 17: Additionality
Additionally


http://gerrit.cloudera.org:8080/#/c/16698/3/java/kudu-client/src/main/java/org/apache/kudu/client/PingRequest.java
File java/kudu-client/src/main/java/org/apache/kudu/client/PingRequest.java:

http://gerrit.cloudera.org:8080/#/c/16698/3/java/kudu-client/src/main/java/org/apache/kudu/client/PingRequest.java@43
PS3, Line 43: makeMasterPingRequest
> It's not something that is done or required at connection time or could eve
I see.  Thank you for the clarification.

With this, it seems Ping() RPC cemented its presence in the API since now :)  I 
guess that's OK, though: I don't see how it could be detrimental in the long 
run anyways.



--
To view, visit http://gerrit.cloudera.org:8080/16698
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I329bd8bde73d247240ae597b677e2cc20a92343a
Gerrit-Change-Number: 16698
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 07 Nov 2020 17:48:04 +0000
Gerrit-HasComments: Yes

Reply via email to