Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16698 )
Change subject: KUDU-1563. Add a feature flag for IGNORE operations ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/16698/3/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java: http://gerrit.cloudera.org:8080/#/c/16698/3/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@2647 PS3, Line 2647: @return true if the cluster supports ignore operations One more thought: since the information about the status of the IGNORE operations is not cached once retrieved (I guess that's intentional, right?), I think it's worth adding a note that this method issues a RPC to the cluster every time it's called, so the callers should strive to call it just once once if no exception is thrown, but not many times (e.g. avoid calling it every time when building a query, etc.). Does it make sense? -- To view, visit http://gerrit.cloudera.org:8080/16698 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I329bd8bde73d247240ae597b677e2cc20a92343a Gerrit-Change-Number: 16698 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sat, 07 Nov 2020 17:55:01 +0000 Gerrit-HasComments: Yes
