Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16703 )
Change subject: [client] use make_shared for a few call sites ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/16703/1/src/kudu/client/client-internal.cc File src/kudu/client/client-internal.cc: http://gerrit.cloudera.org:8080/#/c/16703/1/src/kudu/client/client-internal.cc@563 PS1, Line 563: unique_ptr<Schema> new_schema(new Schema); Not quite sure I understand the difference between 'Schema' and 'Schema()'. http://gerrit.cloudera.org:8080/#/c/16703/1/src/kudu/client/meta_cache.h File src/kudu/client/meta_cache.h: http://gerrit.cloudera.org:8080/#/c/16703/1/src/kudu/client/meta_cache.h@19 PS1, Line 19: #pragma once I know the emphasis of this change list is to use make_shared at some call sites, but do you think it's worth making a separate change list that updates all header files still using an include guard to '#pragma once'? A quick look through the Kudu codebase shows that there are multiple header files that still use an include guard. I think this would be beneficial from a consistency point view. -- To view, visit http://gerrit.cloudera.org:8080/16703 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0c1b8bdfffec596db6a262c195cc94796d1bc1d5 Gerrit-Change-Number: 16703 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Mon, 09 Nov 2020 23:20:31 +0000 Gerrit-HasComments: Yes
