Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16703 )
Change subject: [client] use make_shared for a few call sites ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/16703/1/src/kudu/client/meta_cache.h File src/kudu/client/meta_cache.h: http://gerrit.cloudera.org:8080/#/c/16703/1/src/kudu/client/meta_cache.h@19 PS1, Line 19: #pragma once > Sure I can do that. I didn't know that we slowly migrate the include guard Great, thanks! I guess you could work on that changelist in the background mode. Yup, as you can see, we are migrating to pragma once on file-by-file basis with newer patches de facto: * 4ac1d9f4b4fd477e79859d81a58e2dacbe979b2d * e2509a4bdd807d83535e28f94a3986c4510aa7df * 5316a89dfd13c36eef078b32043f161e6d0bbf01 and other changelists. -- To view, visit http://gerrit.cloudera.org:8080/16703 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0c1b8bdfffec596db6a262c195cc94796d1bc1d5 Gerrit-Change-Number: 16703 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Tue, 10 Nov 2020 00:46:30 +0000 Gerrit-HasComments: Yes
