Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16703 )
Change subject: [client] use make_shared for a few call sites ...................................................................... [client] use make_shared for a few call sites This changelist replaces std::shared_ptr<X> x = new X(...) with std::shared_ptr<X> x = std::make_shared<X>(...) in a few places in Kudu C++ client. The latter form is better from the standpoint of memory allocations count, as described at https://en.cppreference.com/w/cpp/memory/shared_ptr/make_shared#Notes I also modernized the code in updated files a bit. Change-Id: I0c1b8bdfffec596db6a262c195cc94796d1bc1d5 Reviewed-on: http://gerrit.cloudera.org:8080/16703 Tested-by: Kudu Jenkins Reviewed-by: Mahesh Reddy <[email protected]> Reviewed-by: Bankim Bhavsar <[email protected]> --- M src/kudu/client/client-internal.cc M src/kudu/client/meta_cache.cc M src/kudu/client/meta_cache.h 3 files changed, 12 insertions(+), 9 deletions(-) Approvals: Kudu Jenkins: Verified Mahesh Reddy: Looks good to me, but someone else must approve Bankim Bhavsar: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/16703 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I0c1b8bdfffec596db6a262c195cc94796d1bc1d5 Gerrit-Change-Number: 16703 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]>
