Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16779 )
Change subject: WIP KUDU-2612 keep-alive txn heartbeating for C++ client ...................................................................... Patch Set 2: I think being able to serialize/deserialize transactions provide great flexibility. Will the Java Transaction object send heartbeat messages as well? If so, we could just keep it in a container until the end of the transactional session and commit at the end, similarly to how Impala heartbeats Hive ACID transactions. Do we need to create transaction objects to write data or can we just use the txn token? Because if we need to create multiple transaction objects (e.g. in multiple Impala executors), we might need to tell them not to send heartbeats because we are already heartbeating from somewhere else. -- To view, visit http://gerrit.cloudera.org:8080/16779 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0283d8e16908f641388f7a30b513a672df27a186 Gerrit-Change-Number: 16779 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 26 Nov 2020 15:09:09 +0000 Gerrit-HasComments: No
