Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16779 )
Change subject: KUDU-2612 keep-alive txn heartbeating for C++ client ...................................................................... Patch Set 3: > I think being able to serialize/deserialize transactions provide > great flexibility. Will the Java Transaction object send heartbeat > messages as well? If so, we could just keep it in a container until > the end of the transactional session and commit at the end, > similarly to how Impala heartbeats Hive ACID transactions. > Do we need to create transaction objects to write data or can we > just use the txn token? Because if we need to create multiple > transaction objects (e.g. in multiple Impala executors), we might > need to tell them not to send heartbeats because we are already > heartbeating from somewhere else. Thank you for the feedback! Yes, Kudu transaction handle in Java client will send keepalive messages automatically as well. I updated the interface for serialization/deserialization of transaction handles. With that, the original Kudu transaction handle always sends txn keepalive messages, but it's possible to control that behavior for serialized txn tokens, so the result deserialized transactions do or do not send txn keepalive heartbeats as needed. The idea is to mirror this in the Kudu Java client as well. -- To view, visit http://gerrit.cloudera.org:8080/16779 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0283d8e16908f641388f7a30b513a672df27a186 Gerrit-Change-Number: 16779 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Sat, 05 Dec 2020 03:11:42 +0000 Gerrit-HasComments: No
